-
Notifications
You must be signed in to change notification settings - Fork 20
Added proxy field and fix interaction with DOM #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3c719e4 to
a01b7b1
Compare
for more information, see https://pre-commit.ci
This comment was marked as outdated.
This comment was marked as outdated.
|
Hello @eggplants ! I updated this MR, and I also removed the code that was preventing the translation from being received. |
|
Some tests are failing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds proxy support to enable access to DeepL from regions where it may be blocked, and refines DOM interaction by replacing problematic cookie/extension toast handling with direct HTTP response checking.
- Added proxy parameter support using Playwright's ProxySettings type
- Replaced cookie banner and extension toast handling with HTTP response validation
- Enhanced error handling for page load failures with status code reporting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eggplants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Monsterovich Please confirm to pass the tests by running mise run pytest in your local environment.
|
It appears that deepl has blocked access from the Russian Federation.
How to use: