Skip to content

Conversation

@rtavernaea
Copy link
Collaborator

https://edanalytics.atlassian.net/browse/EDFIAL-352 and https://edanalytics.atlassian.net/browse/EDFIAL-353

  • This PR doesn't actually add roles yet, since we will need to separate out login strategies in order to handle this
  • Adds privileges getter to dto that will assign privileges given a role
  • AuthorizedGuard will error if user doesn't have permission for a given route defined in the decorator
    • I copied over all the logging behavior as is from UM. But I know we talked about it being a lot of logging every time no privilege is defined for a route (since most will not have any at first). Thoughts on removing for now and adding it back in once more routes have a privilege defined in auth decorator?

original PR with comments https://github.com/edanalytics/runway_old/pull/107/files

Copy link
Collaborator

@edandylytics edandylytics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good! There's a couple small issues and some cleanup.

Copy link
Collaborator

@edandylytics edandylytics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. One small change to test cleanup and we should be good. Nice job slimming down the auth logic -- much more straightforward now.

Copy link
Collaborator

@edandylytics edandylytics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good!

@rtavernaea rtavernaea merged commit d765f82 into development Jan 21, 2026
7 checks passed
@edandylytics edandylytics mentioned this pull request Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants