Bugfix/obj assess k assess #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalvord1
reviewed
Apr 30, 2025
|
QC checks passed in SC - k_assess are fixed, no changes to row counts |
rlittle08
commented
May 1, 2025
|
current plan for 0.4.7: need to do a rename at the end of the model that renames obj_assess_academic_subject back to academic_subject, to avoid breaking change. Also add comment about why we're doing this strange rename However, for backlog (maybe on next breaking release?) we should probably distinguish the names in stg and in warehouse dims. When we do this, let's explain the nuance in dbt docs |
I have made these ^ changes, tested once again in SC and TX, and confirmed that fct_student_objective_assessment is identical from prod -> dev, but dim_objective_assessment has completely changed k_assessment values, which can now actually join back to dim_assessment for all assessments |
ejoranlienea
approved these changes
May 9, 2025
rlittle08
added a commit
that referenced
this pull request
Jul 2, 2025
* Bugfix/extract descriptor skey (#132) * pass extra arg to correctly handle descriptor in ref; also move lower to end * allow explicit descriptor name * Feature/incremental large stg (#131) * add incremental logic on heaviest stg models (migrated from experiemental branch) * typo * add back conditional so recent deletes are merged in * make int model incremental filtered * need post hook * check var to know * wrong ref * nevermind that doesn't work * make incremental conditional * Update CHANGELOG.md * Feature/Staff Contact Associations Base/Stage (#127) * added base and stage models for staff ed org contact associations * fixed email address name * updated reference in base model, and in stage updated the partition by of the dedupe, the order by, and moved where not is_deleted to the bottom selection * lower email address for future use * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * k_student_assess needs to include stu unique id (#89) * k_student_assess needs to include stu unique id * alphabetize keys * Update CHANGELOG.md --------- Co-authored-by: Jay Kaiser <jayckaiser@gmail.com> * Bugfix/obj assess k assess (#130) * distinguish subject used for both keys * pull through new obj assess subject for stu subj * Update stg_ef3__objective_assessments.sql * rename for consistency in warehouse models * Update CHANGELOG.md * alphabetize keys * Bump/0.4.7 (#134) * 047 changelog notes * Update dbt_project.yml * Hotfix/k obj assess key consistency (#135) * Update stg_ef3__student_objective_assessments.sql * fix obj assess key consistency problems * Bump/0.4.8 (#136) * Update dbt_project.yml * Update CHANGELOG.md * typo in changelog * fix staff sec key for 5.0 and later (#137) * Update CHANGELOG.md (#138) * Fix/Support multiple subjects per course in DS 5.0 (#139) * Add staging model with flattened academic subjects per course for DS 5 * Fix minimum/maximum credits type to float from int According to the Ed-Fi docs, `MaximumAvailableCredits`, `MaximumAvailableCreditsConversion`, `MinimumAvailableCredits`, and `MinimumAvailableCreditsConversion` should all be decimal types, but other edu_edfi_source models (e.g. for course transcripts) keep track of similar fields as floats. Also, adjust indents for surrounding lines to maintain visual alignment. * Document changes in CHANGELOG.md * Move unreleased changes to right section in changelog * feature/model_creation_stu_cte_prog_assoc (#140) * pulled in student cte program associations base and stage models * made requested updates from pull request * added base and stage models to yaml file * updated base/stage yaml files with additional information * updated with remaining columns from v5.2 handbook * created model that flattens program services * removed var from new models * updated all cte models * updated yaml files to enable variables * updated change log with creation of base, stage and secondary stage model for StudentCTEProgramAssociation * Bump/0.4.10 (#141) * Update dbt_project.yml * Update CHANGELOG.md --------- Co-authored-by: Angelica Lastra <107369214+AngelicaLastra@users.noreply.github.com> Co-authored-by: Jay Kaiser <jayckaiser@gmail.com> Co-authored-by: ejoranlienea <ejoranlien@edanalytics.org> Co-authored-by: Alex C. <alchenist@users.noreply.github.com> Co-authored-by: Markisha Berrien-Fitzsimons <markishab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug recently introduce here - #117
The foreign key generation for
k_assessmentwithinobjective_assessmentsis using the wrong value for academic subject. This only impacts cases where objective assessment subject exists and is NOT equal to overall assessment subject.This branch corrects the subject used for k_assessment, but also brings forward both values for subject, so the right one can be used in stg_ef3__student_objective_assessments as well