Skip to content

Conversation

@pgeier
Copy link
Contributor

@pgeier pgeier commented Jan 23, 2026

Description

This PR extends the CodesHandle with additional calls provided by the eccodes API.
Added calls: messageData, messageOffset.

The calls are needed in preparation to rework the CodesContent #128

As the calls are just adding feature, no bad effects are expected at other places.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@pgeier pgeier requested review from Ozaq and simondsmart January 23, 2026 08:56
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.03%. Comparing base (908e6ff) to head (e89c72c).

Files with missing lines Patch % Lines
src/metkit/codes/api/CodesAPI.cc 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #147      +/-   ##
===========================================
- Coverage    71.07%   71.03%   -0.05%     
===========================================
  Files          130      130              
  Lines         8160     8165       +5     
  Branches       781      781              
===========================================
  Hits          5800     5800              
- Misses        2360     2365       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pgeier pgeier force-pushed the feature/METK-143-additional-message-api-calls branch from 7b048c7 to c3bd132 Compare January 23, 2026 11:43
@pgeier pgeier force-pushed the feature/METK-143-additional-message-api-calls branch from c3bd132 to e89c72c Compare January 23, 2026 11:55
@simondsmart simondsmart merged commit b4c9c45 into develop Jan 23, 2026
192 checks passed
@simondsmart simondsmart deleted the feature/METK-143-additional-message-api-calls branch January 23, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants