Refactor CodesContent with new CodesHandle #128
Draft
+304
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #128 +/- ##
===========================================
- Coverage 71.07% 70.52% -0.56%
===========================================
Files 130 132 +2
Lines 8160 8214 +54
Branches 781 783 +2
===========================================
- Hits 5800 5793 -7
- Misses 2360 2421 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pgeier
force-pushed
the
feature/METK-145-Refactor-CodesContent
branch
3 times, most recently
from
330cf6c to
4329de1
Compare
Ozaq
requested changes
Nov 20, 2025
src/metkit/codes/CodesSplitter.cc
Outdated
|
|
||
| return eckit::message::Message(new MallocCodesContent(data, size, 0)); | ||
| return eckit::message::Message( | ||
| new CodesContent(codesHandleFromMessageCopy({static_cast<const uint8_t*>(data.get()), size}))); |
Member
There was a problem hiding this comment.
We need to run this past @simondsmart because we might impact performance due to the additional copy.
pgeier
force-pushed
the
feature/METK-145-Refactor-CodesContent
branch
3 times, most recently
from
86f2a5a to
9eb32f2
Compare
Ozaq
force-pushed
the
feature/METK-145-Refactor-CodesContent
branch
from
9eb32f2 to
a70318a
Compare
pgeier
force-pushed
the
feature/METK-145-Refactor-CodesContent
branch
from
a70318a to
5e17fd3
Compare
Ozaq
approved these changes
Jan 8, 2026
pgeier
force-pushed
the
feature/METK-145-Refactor-CodesContent
branch
3 times, most recently
from
a08adb1 to
2240056
Compare
pgeier
force-pushed
the
feature/METK-145-Refactor-CodesContent
branch
from
769c854 to
ee986b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a copy of CodesContent with the name CodesDataContent.
CodesDataContent is using the new CodesHandle API wrapper to avoid using eccodes directly.
MallocCodesContenthas been removed as it had wrong behaviour - after a modification to the handle in returned the old data array.codesHandleFromFilehas been extended with an optional offset parameterDepending downstream dependencies arefdb- a separate PR (ecmwf/fdb#198) - unfortunately we can not test the CI using both.Contributor Declaration
By opening this pull request, I affirm the following: