Abstract classes for GRIB streams and messages #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses # Conflicts: # cfgrib/abc.py # cfgrib/messages.py
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 96.41% 96.11% -0.31%
==========================================
Files 26 26
Lines 1814 1827 +13
Branches 211 214 +3
==========================================
+ Hits 1749 1756 +7
- Misses 39 44 +5
- Partials 26 27 +1
Continue to review full report at Codecov.
|
|
Hi @alexamici, is this something that we can test already? If so, could you provide a small example of what sort of object Metview should provide, and how to call/test it? Thanks, |
|
@iainrussell I move the core of the change in PR #265 . It should be almost ready for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #243