[marker] store data and clean on file deletion #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Sep 22, 2017
| @@ -117,6 +126,69 @@ export abstract class MarkerManager<D extends object> { | |||
| protected readonly uri2MarkerCollection = new Map<string, MarkerCollection<D>>(); | |||
| protected readonly onDidChangeMarkersEmitter = new Emitter<void>(); | |||
|
|
|||
| initialized: Promise<void>; | |||
| window.onunload = () => { | ||
| for (const contribution of this.contributions.getContributions()) { | ||
| if (contribution.onStop) { | ||
| contribution.onStop(this); |
There was a problem hiding this comment.
Should we do try/catch here? that once contribution does not break others
svenefftinge
force-pushed
the
GH-540
branch
from
e8c2c84 to
15666ac
Compare
…#540) Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge
force-pushed
the
GH-540
branch
from
15666ac to
9487a1b
Compare
|
I need this change for the next PR. Can I merge? |
hexa00
approved these changes
Sep 22, 2017
| */ | ||
| onStart?(app: FrontendApplication): void; | ||
|
|
||
|
|
There was a problem hiding this comment.
https://palantir.github.io/tslint/rules/no-consecutive-blank-lines/ can catch such cases
There was a problem hiding this comment.
Would also be good if our autoformatting would clean that already.
| */ | ||
| onStart(app: FrontendApplication): void; | ||
| onStop?(app: FrontendApplication): void |
| constructor( | ||
| @inject(WidgetManager) protected widgetManager: WidgetManager, | ||
| @inject(ILogger) protected logger: ILogger, | ||
| @inject(StorageService) protected storageService: StorageService) { } | ||
|
|
||
| onStart(app: FrontendApplication): void { | ||
| const storageKey = 'layout'; | ||
| this.storageService.getData(storageKey, undefined).then((serializedLayoutData: string | undefined) => { | ||
| this.storageService.getData(this.storageKey, undefined).then((serializedLayoutData: string | undefined) => { |
There was a problem hiding this comment.
You don't need to specify the undefined default... but I don't mind
| @@ -117,6 +126,69 @@ export abstract class MarkerManager<D extends object> { | |||
| protected readonly uri2MarkerCollection = new Map<string, MarkerCollection<D>>(); | |||
| protected readonly onDidChangeMarkersEmitter = new Emitter<void>(); | |||
|
|
|||
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge
force-pushed
the
GH-540
branch
from
9487a1b to
f9c7197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A marker-service will remove markers when a file gets deleted.
A marker-service will persist marker information between sessions.