Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode's formatter and the TS linter rules are not in sync #413

Open
kittaakos opened this issue Aug 23, 2017 · 3 comments
Open

VSCode's formatter and the TS linter rules are not in sync #413

kittaakos opened this issue Aug 23, 2017 · 3 comments
Labels
bug bugs found in the application linting issues related to linting

Comments

@kittaakos
Copy link
Contributor

It happens with the destructuring assignments.

Unformatted code:

function foo() {
    const arr = [1, 2, 3];
    const [head, ] = arr;
    console.log(head);
}

Formatted code:

function foo() {
    const arr = [1, 2, 3];
    const [head,] = arr;
    console.log(head);
}

After formatting the code once can see a warning at [head,] from the linter.

@kittaakos kittaakos added the bug bugs found in the application label Aug 24, 2017
@kittaakos
Copy link
Contributor Author

Eventually, this results in a build failure on the CI for #165.

kittaakos added a commit that referenced this issue Aug 24, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Sep 8, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
jbicker pushed a commit that referenced this issue Sep 19, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
jbicker pushed a commit that referenced this issue Sep 26, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
jbicker pushed a commit that referenced this issue Sep 27, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
jbicker pushed a commit that referenced this issue Sep 28, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Sep 29, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Oct 4, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Oct 6, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
svenefftinge pushed a commit that referenced this issue Oct 10, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
@vince-fugnitto vince-fugnitto added the linting issues related to linting label Feb 27, 2020
@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 5, 2021

@kittaakos is this still the case and what could we do to improve the situation?

@kittaakos
Copy link
Contributor Author

is this still the case

Yes, it is.

screencast 2021-03-05 17-19-28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application linting issues related to linting
Projects
None yet
Development

No branches or pull requests

3 participants