Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2027: Fixed failing test case on OS X. #2028

Closed
wants to merge 1 commit into from
Closed

GH-2027: Fixed failing test case on OS X. #2028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
GH-2027: Fixed failing test case on OS X. 
The tests are OS agnostic, so we need to set `isOSX` to `false` on OS X.
Otherwise, the test fails.

Closes: #2027.
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
  • Loading branch information
@kittaakos
kittaakos committed Jun 4, 2018
commit b59b3c95e91a8abe0010413fb358aab91b5e1372
2 changes: 2 additions & 0 deletions packages/core/src/browser/keybinding.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ describe("keys api", () => {
});

it("should parse a string containing special modifiers to a KeyCode correctly", () => {
const stub = sinon.stub(os, 'isOSX').value(false);
const keycode = KeyCode.parse("ctrl+b");
expect(keycode.ctrl).to.be.true;
expect(keycode.key).is.equal(Key.KEY_B);
Expand All @@ -344,6 +345,7 @@ describe("keys api", () => {
expect(keycodeCtrlOrCommand.meta).to.be.false;
expect(keycodeCtrlOrCommand.ctrl).to.be.true;
expect(keycodeCtrlOrCommand.key).is.equal(Key.KEY_B);
stub.restore();
});

it("should parse a string containing special modifiers to a KeyCode correctly (macOS)", () => {
Expand Down