GH-2027: Fixed failing test case on OS X. #2028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are OS agnostic, so we need to set `isOSX` to `false` on OS X. Otherwise, the test fails. Closes: #2027. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
|
I have opened this on friday, which should fix the tests: |
|
Great! Closing in favor of #2016. |
kittaakos
added a commit
that referenced
this pull request
Jun 11, 2018
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 11, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 11, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 12, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 12, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 13, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 13, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 13, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 13, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 15, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 15, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 18, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 20, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 20, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos
added a commit
that referenced
this pull request
Jun 27, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
added a commit
that referenced
this pull request
Jun 27, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
added a commit
that referenced
this pull request
Jun 27, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
added a commit
that referenced
this pull request
Jun 27, 2018
Closes: #2026. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
marcdumais-work
pushed a commit
to marcdumais-work/theia
that referenced
this pull request
Oct 15, 2018
Closes: eclipse-theia#2026. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are OS agnostic, so we need to set
isOSXtofalseon OS X.Otherwise, the test fails.
Closes: #2027.
Signed-off-by: Akos Kitta kittaakos@gmail.com