Skip to content

Update CODEOWNERS for PMP part #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pahmann wants to merge 1 commit into from
Closed

Update CODEOWNERS for PMP part #2351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Copy link
Contributor

@masc2023 masc2023 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more updates, Safety Manager are responsible also for other work products, e.g. Safety Managent Plan, see here #2352, PanDoe not added as reviewer

Copy link
Member

@anmittag anmittag Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pahmann general question: why do we use user-names here and not work with Teams and is it an "AND" or and "OR" relation?

Copy link
Contributor

@masc2023 masc2023 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teams does not work, it is "OR"

Copy link
Member

@anmittag anmittag Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masc2023 well

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

tells also Teams are working if you ensure:

"The people you choose as code owners must have write permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership."

Copy link
Contributor

@masc2023 masc2023 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a technical topics i am referring to, lets discuss that next year with @aschemmel-tech , as he tried it out and did not work as expected

Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ verification/ @eclipse-score/automotive-score-committers
/docs/manuals/ @eclipse-score/automotive-score-committers
/docs/modules/ @eclipse-score/automotive-score-committers
# /docs/platform_management_plan/ @eclipse-score/community-process
/docs/platform_management_plan/ @pahmann @PhilipPartsch @masc2023 @aschemmel-tech
/docs/platform_management_plan/ @pahmann @PhilipPartsch @masc2023 @aschemmel-tech @PandaeDo
# /docs/quality/ @eclipse-score/quality-managers
/docs/quality/ @masc2023 @pahmann @PandaeDo
# /docs/requirements/stakeholder/ @eclipse-score/automotive-score-technical-leads
Expand Down