Skip to content

Conversation

@pahmann
Copy link
Member

@pahmann pahmann commented Dec 16, 2025

@PandaeDo is safety manager and quality manager, but misses the right to submit approving of the PMP, which should be changed by an update of the CODEOWNER file.

@PandaeDo misses the right to review the PMP, which should be changed

Signed-off-by: Philipp Ahmann <2428012+pahmann@users.noreply.github.com>
@pahmann pahmann changed the title Update CODEOWNERS Update CODEOWNERS for PMP part Dec 16, 2025
@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@masc2023
Copy link
Contributor

@PandaeDo is safety manager and quality manager, but misses the right to submit approving of the PMP, which should be changed by an update of the CODEOWNER file.

What is here the reference, only the selected roles in meritocratic way counts, as done here?
https://eclipse-score.github.io/score/main/platform_management_plan/role_assignment/platform_safety_manager.html

If this is agreed, then first other roles should be elected, and properly updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more updates, Safety Manager are responsible also for other work products, e.g. Safety Managent Plan, see here #2352, PanDoe not added as reviewer

Copy link
Member

@anmittag anmittag Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pahmann general question: why do we use user-names here and not work with Teams and is it an "AND" or and "OR" relation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teams does not work, it is "OR"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masc2023 well

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

tells also Teams are working if you ensure:

"The people you choose as code owners must have write permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a technical topics i am referring to, lets discuss that next year with @aschemmel-tech , as he tried it out and did not work as expected

Copy link
Contributor

@FScholPer FScholPer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLs or TLs should also be in that list

@masc2023
Copy link
Contributor

masc2023 commented Dec 17, 2025

PLs or TLs should also be in that list

No, as defined here, https://eclipse-score.github.io/process_description/main/general_concepts/score_review_concept.html
PLs are responsible, but approval by Process Community, which is reflected in the CODEOWNER File

TLs as discussed Role does not exists any more, at least in Process Description

@pahmann
Copy link
Member Author

pahmann commented Dec 17, 2025

I see that this will become a lengthy discussion potentially. I spotted that @PandaeDo was not listed as reviewer when I opened PMP related PR in this repo. I expected he will be eliable reviewer based on his role and position within the process community. I had no intention to check the whole CODEOWNERS file for missing or wrong assignment, rather perform an atomic fix in a single line, where I spotted a potential flaw. (Change sets should be small, so that they can be understood and easily merged. This was my further rational.
Based on the feedback from @masc2023 and @FScholPer, I will close this PR with this comment. It can be reopened and merged if someone likes to.

@pahmann pahmann closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants