-
Notifications
You must be signed in to change notification settings - Fork 76
Update CODEOWNERS for PMP part #2351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@PandaeDo misses the right to review the PMP, which should be changed Signed-off-by: Philipp Ahmann <2428012+pahmann@users.noreply.github.com>
|
The created documentation from the pull request is available at: docu-html |
What is here the reference, only the selected roles in meritocratic way counts, as done here? If this is agreed, then first other roles should be elected, and properly updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs more updates, Safety Manager are responsible also for other work products, e.g. Safety Managent Plan, see here #2352, PanDoe not added as reviewer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teams does not work, it is "OR"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masc2023 well
tells also Teams are working if you ensure:
"The people you choose as code owners must have write permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a technical topics i am referring to, lets discuss that next year with @aschemmel-tech , as he tried it out and did not work as expected
FScholPer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLs or TLs should also be in that list
No, as defined here, https://eclipse-score.github.io/process_description/main/general_concepts/score_review_concept.html TLs as discussed Role does not exists any more, at least in Process Description |
|
I see that this will become a lengthy discussion potentially. I spotted that @PandaeDo was not listed as reviewer when I opened PMP related PR in this repo. I expected he will be eliable reviewer based on his role and position within the process community. I had no intention to check the whole CODEOWNERS file for missing or wrong assignment, rather perform an atomic fix in a single line, where I spotted a potential flaw. (Change sets should be small, so that they can be understood and easily merged. This was my further rational. |
@PandaeDo is safety manager and quality manager, but misses the right to submit approving of the PMP, which should be changed by an update of the CODEOWNER file.