-
Notifications
You must be signed in to change notification settings - Fork 24
Refactor self-move warning suppression #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed GCC specific pragma for self-move warning suppression, in score gcc version 12 is used and the warning is not available in this version Signed-off-by: bvbogdan <vasile-bogdan.badicu@aumovio.com>
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
doodspav
approved these changes
Dec 11, 2025
doodspav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Points to note:
- we do not expect to move to GCC13 anytime soon (which is when the warning was added)
- users should be building Persistency using SCore's toolchain, so they wouldn't see this warning either
- we can add it back if we migrate GCC versions, no point in polluting our code with unnecessary pragmas for now
umaucher
approved these changes
Dec 15, 2025
antonkri
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed GCC specific pragma for self-move warning suppression, in score gcc version 12 is used and the warning is not available in this version
Fixes: #180