CPP: `reference_integration` treats warnings as errors

[PiotrKorkus]

In reference_integration repository there is a gcc configuration that treats warnings as errors.
Surpressing an error in

persistency/src/cpp/tests/test_kvs.cpp

Lines 35 to 48 in 8699447

	/* Ignore Compiler Warning "Wself-move" for GCC and CLANG*/
	#if defined(__clang__)
	#pragma clang diagnostic push
	#pragma clang diagnostic ignored "-Wself-move"
	#elif defined(__GNUC__)
	#pragma GCC diagnostic push
	#pragma GCC diagnostic ignored "-Wself-move"
	#endif
	kvs_a = std::move(kvs_a); /* Intentional self-move */
	#if defined(__clang__)
	#pragma clang diagnostic pop
	#elif defined(__GNUC__)
	#pragma GCC diagnostic pop
	#endif

creates an error in unit test execution in reference_integration repository with:

bazel test @score_persistency//:test_kvs_cpp

We need to repeat tests there to collect combined results and calculate coverages.

[vbogdanb]

Why are unit test treated as error as inside unit test usually some hacks are required to ensure the coverage?

[AlexanderLanin]

Are the pragmas not working, or is it some other warning that is problematic here?

[PiotrKorkus]

Error message:

external/score_persistency+/src/cpp/tests/test_kvs.cpp: In member function 'virtual void kvs_constructor_move_constructor_Test::TestBody()':
external/score_persistency+/src/cpp/tests/test_kvs.cpp:41:36: error: unknown option after '#pragma GCC diagnostic' kind [-Werror=pragmas]
   41 |     #pragma GCC diagnostic ignored "-Wself-move"
      |                                    ^~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
Use --verbose_failures to see the command lines of failed build steps.

[AlexanderLanin]

There is no self-move warning in gcc?! That's what it is saying. It cannot disable the warning, because there is no such warning.

Did you build with gcc within persistency or only llvm?

[vbogdanb]

No we us gcc.
But that is not the issue, the issue is the gcc version in score is 12 , and that one doesn't have that option as it was introduces in 13.
Will remove then.

[AlexanderLanin]

@vbogdanb I'm not sure what happened to the discussion to use a gcc from this century 😆
See eclipse-score/score#1730