Skip to content

[Win32] Fix deletion of read-only files not working with Java 25 #2178 #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

[Win32] Fix deletion of read-only files not working with Java 25 #2178 #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31d3a1d
[Win32] Fix deletion of read-only files not working with Java 25 #2178
HeikoKlare Oct 1, 2025
51ba044
Version bump(s) for 4.38 stream
eclipse-platform-bot Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/bundles/org.eclipse.core.filesystem/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.core.filesystem; singleton:=true
Bundle-Version: 1.11.300.qualifier
Bundle-Version: 1.11.400.qualifier
Bundle-Localization: plugin
Require-Bundle: org.eclipse.equinox.common;bundle-version="[3.18.0,4.0.0)",
org.eclipse.equinox.registry;bundle-version="[3.2.0,4.0.0)",
Expand Down
7 changes: 7 additions & 0 deletions ...org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/LocalFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
import org.eclipse.core.runtime.MultiStatus;
import org.eclipse.core.runtime.NullProgressMonitor;
import org.eclipse.core.runtime.OperationCanceledException;
import org.eclipse.core.runtime.Platform.OS;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.SubMonitor;
import org.eclipse.osgi.util.NLS;
Expand Down Expand Up @@ -314,6 +315,12 @@ private IStatus internalDelete(File target, InfiniteProgress infMonitor, Executo
} catch (AccessDeniedException e) {
// If the file is read only, it can't be deleted via Files.deleteIfExists()
// see https://bugs.eclipse.org/bugs/show_bug.cgi?id=500306
// Since Java 25, just calling File#delete() is not sufficient anymore on Windows
// but the read-only state has to be cleared explicitly,
// see https://bugs.openjdk.org/browse/JDK-8355954
if (OS.isWindows()) {
target.setWritable(true);
}
if (target.delete()) {
infMonitor.worked();
return Status.OK_STATUS;
Expand Down
Loading