[Win32] Fix deletion of read-only files not working with Java 25 #2178 #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pse-platform#2178 With Java 25, the behavior of File#delete() has been changed for read-only files on Windows. Previously, the operation also removed read-only files whereas now the operation fails in that case. LocalFile#delete() depends on the preexisting behavior. It ensures that read-only files are also deleted. In order to preserve the behavior with Java 25, this change makes LocalFile#delete() explicitly remove the read-only attribute when deleting a read-only file on WIndows. Fixes eclipse-platform#2178
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
iloveeclipse
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Java 25, the behavior of File#delete() has been changed for read-only files on Windows. Previously, the operation also removed read-only files whereas now the operation fails in that case. LocalFile#delete() depends on the preexisting behavior. It ensures that read-only files are also deleted.
In order to preserve the behavior with Java 25, this change makes LocalFile#delete() explicitly remove the read-only attribute when deleting a read-only file on WIndows.
Fixes #2178