Skip to content

Add deprecation for removal notices in Util class #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Add deprecation for removal notices in Util class #2966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions bundles/org.eclipse.jface/src/org/eclipse/jface/util/Util.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ public static String replaceAll(String src, String find, String replacement) {
* Windowing system constant.
* @since 3.5
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2025-03") // 2025-03 was added later for information purposes
public static final String WS_MOTIF = "motif";//$NON-NLS-1$

/**
Expand All @@ -514,14 +514,14 @@ public static String replaceAll(String src, String find, String replacement) {
* Windowing system constant.
* @since 3.5
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2025-03") // 2025-03 was added later for information purposes
public static final String WS_PHOTON = "photon";//$NON-NLS-1$

/**
* Windowing system constant.
* @since 3.5
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2025-03") // 2025-03 was added later for information purposes
public static final String WS_CARBON = "carbon";//$NON-NLS-1$

/**
Expand All @@ -534,6 +534,7 @@ public static String replaceAll(String src, String find, String replacement) {
* Windowing system constant.
* @since 3.5
*/
@Deprecated(forRemoval = true, since = "2025-03") // 2025-03 was added later for information purposes
public static final String WS_WPF = "wpf";//$NON-NLS-1$

/**
Expand Down Expand Up @@ -587,7 +588,7 @@ public static boolean isGtk() {
* @return <code>true</code> for motif platforms
* @since 3.5
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2025-03") // 2025-03 was added later for information purposes
public static boolean isMotif() {
final String ws = SWT.getPlatform();
return WS_MOTIF.equals(ws);
Expand All @@ -598,7 +599,7 @@ public static boolean isMotif() {
* @return <code>true</code> for photon platforms
* @since 3.5
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2025-03") // 2025-03 was added later for information purposes
public static boolean isPhoton() {
final String ws = SWT.getPlatform();
return WS_PHOTON.equals(ws);
Expand All @@ -609,7 +610,7 @@ public static boolean isPhoton() {
* @return <code>true</code> for carbon platforms
* @since 3.5
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2025-03") // 2025-03 was added later for information purposes
public static boolean isCarbon() {
final String ws = SWT.getPlatform();
return WS_CARBON.equals(ws);
Expand All @@ -630,6 +631,7 @@ public static boolean isCocoa() {
* @return <code>true</code> for WPF
* @since 3.5
*/
@Deprecated(forRemoval = true, since = "2025-03") // 2025-03 was added later for information purposes
public static boolean isWpf() {
final String ws = SWT.getPlatform();
return WS_WPF.equals(ws);
Expand Down
1 change: 1 addition & 0 deletions ...s/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/keys/BindingPersistence.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ private static final void readBindingsFromPreferences(final IMemento preferences
* @param commandService The command service for the workbench; must
* not be <code>null</code>.
*/
@SuppressWarnings("removal")
private static final void readBindingsFromRegistry(final IConfigurationElement[] configurationElements,
final int configurationElementCount, final BindingManager bindingManager,
final CommandManager commandService) {
Expand Down
1 change: 1 addition & 0 deletions ...lipse.ui.workbench/eclipseui/org/eclipse/ui/internal/quickaccess/QuickAccessContents.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ public boolean getShowAllMatches() {
return showAllMatches;
}

@SuppressWarnings("removal")
private void refreshTable(QuickAccessElement perfectMatch, List<QuickAccessEntry>[] entries, String filter) {
if (table.isDisposed()) {
return;
Expand Down
2 changes: 2 additions & 0 deletions ...g.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/keys/BindingPersistenceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ public final void testAutoLoad() throws ParseException {
}

@Test
@SuppressWarnings("removal")
public final void testSinglePlatform() throws Exception {
ParameterizedCommand about = new ParameterizedCommand(commandService
.getCommand("org.eclipse.ui.help.aboutAction"), null);
Expand Down Expand Up @@ -182,6 +183,7 @@ public final void testSinglePlatform() throws Exception {

@Ignore
@Test
@SuppressWarnings("removal")
public final void TODOtestBindingTransform() throws Exception {
ParameterizedCommand addWS = new ParameterizedCommand(commandService
.getCommand("org.eclipse.ui.navigate.addToWorkingSet"), null);
Expand Down
Loading