Add deprecation for removal notices in Util class #2966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Test Results 1 824 files ±0 1 824 suites ±0 1h 52m 14s ⏱️ + 12m 50s For more details on these failures, see this check. Results for commit f87189b. ± Comparison against base commit a44d462. ♻️ This comment has been updated with latest results. |
|
tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/keys/BindingPersistenceTest.java needs update in its "ignore deprecation annotation". |
Follow-up work for commit eclipse-platform@9ee38b5
|
Thank you for the hint. I ended up deprecating also some related methods that were using only the deprecated constants and added the corresponding |
|
Test failure is unrelated #294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2964 (comment)