New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casting parameter type to fit the template in `generateS390CompareAndBranchInstruction` #6725

Merged

fjeremic merged 1 commit into eclipse-openj9:master from simonameng:tplBRC2

Aug 27, 2019

Contributor

simonameng commented Aug 12, 2019 •

edited

Loading

Typecast immediate value parameter for generateS390CompareAndBranchInstruction to either int32_t or int64_t to use newly added function template. Also remove unnecessary return typecasting.

Contributor Author

simonameng commented Aug 12, 2019

The new added template: eclipse-omr/omr#4200

Contributor Author

simonameng commented Aug 12, 2019

@r30shah @joransiu

r30shah requested changes

View reviewed changes

Contributor

r30shah left a comment

There is a typo in PR description (Used Casing instead of Casting. Can you fix that. There is only one more suggestion which I have put in review. Apart from that looks good to me.

runtime/compiler/z/codegen/J9S390PrivateLinkage.cpp Outdated Show resolved Hide resolved

genie-openj9 commented Aug 13, 2019

Can one of the admins verify this patch?

4 similar comments

genie-openj9 commented Aug 13, 2019

Can one of the admins verify this patch?

genie-openj9 commented Aug 13, 2019

Can one of the admins verify this patch?

genie-openj9 commented Aug 13, 2019

Can one of the admins verify this patch?

genie-openj9 commented Aug 13, 2019

Can one of the admins verify this patch?

simonameng force-pushed the tplBRC2 branch from e3e2916 to 0c2b4e8 Compare

August 13, 2019 15:12

r30shah approved these changes

View reviewed changes

Contributor

r30shah left a comment

Changes looks good to me. Will leave to @joransiu to take another look before we can merge this guy.

r30shah mentioned this pull request

Add template for function generateS390CompareAndBranchInstruction eclipse-omr/omr#4200

Merged

r30shah approved these changes

View reviewed changes

runtime/compiler/z/codegen/ReduceSynchronizedFieldLoad.cpp Show resolved Hide resolved

joransiu added arch:z comp:jit labels

joransiu approved these changes

View reviewed changes

Member

joransiu left a comment

LGTM

Member

joransiu commented Aug 14, 2019

Jenkins test sanity zlinux depends eclipse-omr/omr#4200

Member

joransiu commented Aug 14, 2019

Jenkins test sanity zlinux jdk8 depends eclipse-omr/omr#4200


          Typecast parameter for generateS390CompareAndBranchInstruction and …

f989748

…remove unnecessary typecast

Typecast immediate value parameter for `generateS390CompareAndBranchInstruction` to either `int32_t` or `int64_t` to use newly added function template.

Also remove unnecessary return typecasting.

Signed-off-by: simonameng <simonameng97@gmail.com>

simonameng force-pushed the tplBRC2 branch from 44b0910 to f989748 Compare

August 15, 2019 14:42

fjeremic self-assigned this

fjeremic approved these changes

View reviewed changes

Contributor

fjeremic left a comment

Will need to wait for OMR-Acceptance to merge this one.

fjeremic merged commit b645c0c into eclipse-openj9:master

JasonFengJ9 mentioned this pull request

s390x/compressedrefs/libj9jit29.so: undefined symbol: _Z39generateS390CompareAndBranchInstructionIjEPN2TR11InstructionEPNS0 #6862

Closed

simonameng deleted the tplBRC2 branch

February 18, 2020 16:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch:z comp:jit