Add template for function generateS390CompareAndBranchInstruction
#4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r30shah
reviewed
Aug 12, 2019
…nd cast the relevant use cases Adding template for function `generateS390CompareAndBranchInstruction` and initialize it to pass in int32_t or int64_t type only for the parameter `second`.Also, cast the type of the parameter to either int32_t or int64_t in the use cases if needed. Adding a new signiture to have it pass in `TR::RealRegister *` type for parameter `second`, and casting it to `TR::Register *` type to use the relevant function. Signed-off-by: simonameng <simonameng97@gmail.com>
|
Since we found the use cases which pass in |
fjeremic
reviewed
Aug 13, 2019
…hInstruction` Delete the `TR::RealRegister` version of `generateS390CompareAndBranchInstruction` since alreay typecasted the relevant argument to `TR::Register` from `TR::RealRegister`. Signed-off-by: simonameng <simonameng97@gmail.com>
r30shah
suggested changes
Aug 14, 2019
For the use cases with op code `TR::InstOpCode::CL`, treat the immediate value as `int32_t` type. And for the use cases with op code `TR::InstOpCode::CLG`, treat the immediate value as `int64_t` type. Signed-off-by: simonameng <simonameng97@gmail.com>
fjeremic
approved these changes
Aug 27, 2019
|
@genie-omr build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding template for function
generateS390CompareAndBranchInstructionand declaring it to acceptint32_torint64_ttype only for parametersecond. Also, casting parameters in the use cases which don't fit the declaration.Closes: #3878