Add JFR logging structures and for GC events #23076
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This was referenced Dec 8, 2025
adpopescu
force-pushed
the
jfr-gc-logging-2
branch
from
43d5fb5 to
a2e5fb1
Compare
This change add a new api for a unique cycle ID. This should set the ID consistently for use throughout the entirety of the cycle. Also moving GC count to be incremented just before cycle start to be consistent with how it's now being done in OMR see eclipse-omr/omr#8065 Signed-off-by: Adrian Popescu <adpopescu@ibm.com>
This change adds all the necessary structures to add some new GC JFR events. Also adding JFR OldGarbageCollection event and test. Signed-off-by: Adrian Popescu <adpopescu@ibm.com>
adpopescu
force-pushed
the
jfr-gc-logging-2
branch
from
a2e5fb1 to
08e257e
Compare
theresa-m
reviewed
Dec 12, 2025
| } | ||
|
|
||
| /** | ||
| * API to return a unique GC ID based on what is set in cycle state. Returns 0 if there is no active GC cycle. |
Contributor
There was a problem hiding this comment.
I recommend to put information about the return value next to @return.
| <output type="success" caseSensitive="yes" regex="no">classLoader</output> | ||
| <output type="failure" caseSensitive="yes" regex="no">jfr print: could not read recording</output> | ||
| </test> | ||
| <test id="test jfr OldGarbageCollection - approx 30 seconds"> |
Contributor
There was a problem hiding this comment.
Should there be tests for the other new events as well?
| * @param userData[in] the registered user data | ||
| */ | ||
| static void | ||
| jfrOldGarbageCollection(J9HookInterface **hook, UDATA eventNum, void *eventData, void* userData) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds all the necessary structures to add some new
GC JFR events. Also adding JFR OldGarbageCollection event and test.
Depends on #23074