Add apis for GC unique cycle ID #23074
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
closed wrong PR... |
amicic
reviewed
Dec 8, 2025
amicic
reviewed
Dec 8, 2025
adpopescu
force-pushed
the
gc-unique-ids
branch
2 times, most recently
from
6cabc34 to
844acb4
Compare
amicic
reviewed
Dec 8, 2025
amicic
reviewed
Dec 8, 2025
adpopescu
force-pushed
the
gc-unique-ids
branch
from
844acb4 to
76b0e11
Compare
Contributor
|
Looks ok. Let's just be a bit more specific in the PR comment. Instead of |
amicic
reviewed
Dec 8, 2025
adpopescu
force-pushed
the
gc-unique-ids
branch
from
76b0e11 to
59e7c7c
Compare
Contributor
Author
Changed comment. |
adpopescu
force-pushed
the
gc-unique-ids
branch
2 times, most recently
from
597b0da to
4f05ec6
Compare
adpopescu
force-pushed
the
gc-unique-ids
branch
2 times, most recently
from
e77f523 to
5c0f3ca
Compare
amicic
reviewed
Dec 10, 2025
amicic
reviewed
Dec 10, 2025
This change add a new api for a unique cycle ID. This should set the ID consistently for use throughout the entirety of the cycle. Also moving GC count to be incremented just before cycle start to be consistent with how it's now being done in OMR see eclipse-omr/omr#8065 Signed-off-by: Adrian Popescu <adpopescu@ibm.com>
adpopescu
force-pushed
the
gc-unique-ids
branch
from
5c0f3ca to
5824ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add a new api for a unique cycle ID. This should set the ID
consistently for use throughout the entirety of the cycle. Also moving
GC count to be incremented just before cycle start to be consistent with
how it's now being done in OMR see
eclipse-omr/omr#8065