Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install VS2019 for Java 15 Windows builds #9805

Closed
pshipton opened this issue Jun 4, 2020 · 10 comments
Closed

Install VS2019 for Java 15 Windows builds #9805

pshipton opened this issue Jun 4, 2020 · 10 comments

Comments

@pshipton
Copy link
Member

pshipton commented Jun 4, 2020

The default compiler for Java 15 is VS2019. It needs to be installed on at least one machine so we can test OpenJ9 with it, and then once confirmed working, rolled out to them all. Since it's the default for Java 15, if it doesn't just work with OpenJ9 we'll need to configure Java 15 (next) to build with an older version until it's working.

@pshipton
Copy link
Member Author

pshipton commented Jun 4, 2020

@jdekonin

@pshipton pshipton added this to the Release 0.22 (Java 15) milestone Jul 22, 2020
jdekonin added a commit to jdekonin/adoptium-infrastructure that referenced this issue Jul 30, 2020
* eclipse-openj9/openj9#9805
* add top level main.yml, MSVS_2019 role and add openssl 1.1.1g built with VS2019

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
@jdekonin
Copy link
Contributor

Adopt playbook updates for this found here :
adoptium/infrastructure#1481

@jdekonin
Copy link
Contributor

jdekonin commented Jul 30, 2020

Installed VS2019 on win2012r2-x86-6. It appears to be under 3G total.

  • win2012r2-x86-1
  • win2012r2-x86-2
  • win2012r2-x86-3
  • win2012r2-x86-4
  • win2012r2-x86-5
  • win2012r2-x86-6

jdekonin added a commit to jdekonin/adoptium-infrastructure that referenced this issue Jul 30, 2020
* eclipse-openj9/openj9#9805
* add top level main.yml, MSVS_2019 role and add openssl 1.1.1g built with VS2019

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
@jdekonin
Copy link
Contributor

Opened #10303 to help address space issues that this is going to have with the addition of VS2013 (#10129) and VS2019.

@pshipton
Copy link
Member Author

Note we don't need VS2010 once moved to VS2013. We can stage the move. i.e. start on one machine, remove the build label, remove 2010, install 2013, ensure the JVM can build on 2013 and pass testing. Add back the build label to this machine, do the other machines one by one.

@pshipton
Copy link
Member Author

The above suggestion temporarily allows some builds to use 2013 and some to use 2010, but ideally this time period will be minimized. The -Xinternalversion option shows which version of the compiler was used to build.

@pshipton
Copy link
Member Author

Ah, I guess supporting both 2010 and 2013 at the same time isn't feasible due to the settings in defaults.yml. In this case, remove the build labels from the 2010 machines and commit to updating at least a couple of machines in the same day.

@jdekonin
Copy link
Contributor

We are constantly on the edge with space on these systems. Even with the compile juggling the systems are only going to have ~10G free. While that is an option, the bit of extra space would avoid future failures due to lack of space.

@pshipton
Copy link
Member Author

pshipton commented Jul 30, 2020

Yup, just thinking of alternatives for (a) you don't get additional space in time for the Java 15 release which is coming up quicky, or (b) you don't get additional space ever.

@jdekonin
Copy link
Contributor

Work is complete, waiting on fix for #9967.

jdekonin added a commit to jdekonin/adoptium-infrastructure that referenced this issue Aug 17, 2020
* eclipse-openj9/openj9#9805
* add top level main.yml, MSVS_2019 role and add openssl 1.1.1g built with VS2019

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/adoptium-infrastructure that referenced this issue Aug 17, 2020
* eclipse-openj9/openj9#9805
* add top level main.yml, MSVS_2019 role and add openssl 1.1.1g built with VS2019

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/adoptium-infrastructure that referenced this issue Aug 18, 2020
* eclipse-openj9/openj9#9805
* add top level main.yml, MSVS_2019 role and add openssl 1.1.1g built with VS2019

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
Willsparker pushed a commit to adoptium/infrastructure that referenced this issue Aug 19, 2020
* eclipse-openj9/openj9#9805
* add top level main.yml, MSVS_2019 role and add openssl 1.1.1g built with VS2019

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants