Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Windows jdk8 compiles to VS2013 #10129

Closed
pshipton opened this issue Jul 9, 2020 · 5 comments
Closed

Move Windows jdk8 compiles to VS2013 #10129

pshipton opened this issue Jul 9, 2020 · 5 comments

Comments

@pshipton
Copy link
Member

pshipton commented Jul 9, 2020

As VS2010 is going out of support July 14, we should change the compiler used to build Windows jdk8. The highest supported level atm is VS2013 according to https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/openj9/common/autoconf/toolchain_windows.m4

We'll need the compiler installed on the build machines, and check if any changes are needed for OpenJ9 to compile (we know it works with VS2017).

@pshipton
Copy link
Member Author

pshipton commented Jul 9, 2020

@jdekonin

@jdekonin
Copy link
Contributor

jdekonin commented Jul 9, 2020

We aren't going to have enough space for builds unless we can either delete vs2010 or get more hard disk. Current systems have between 17-21G free which is what is available for compile/test jobs.

@pshipton
Copy link
Member Author

pshipton commented Jul 9, 2020

Seems to me the current installations are bloated, installing all VS components instead of just the subset required to compile and link. While we can delete VS2010 once VS2013 is working, during the transition we'll need both. How about removing VS2010 on one machine and installing VS2013 instead. We'll need to adjust the labels and build requirements to manage it. Once we prove the build is working on the single machine, the same change can be done to the rest.

@pshipton pshipton mentioned this issue Jul 29, 2020
jdekonin added a commit to jdekonin/openj9-openjdk-jdk8 that referenced this issue Oct 15, 2020
* [skip ci]
* eclipse-openj9/openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/openj9-openjdk-jdk8 that referenced this issue Oct 15, 2020
* [skip ci]
* eclipse-openj9/openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/openj9-openjdk-jdk8 that referenced this issue Oct 15, 2020
* [skip ci]
* eclipse-openj9/openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/openj9-openjdk-jdk8 that referenced this issue Oct 15, 2020
* [skip ci]
* disable the use of rebase
* eclipse-openj9/openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/openj9 that referenced this issue Oct 16, 2020
* [skip ci]
* eclipse-openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/openj9-openjdk-jdk8 that referenced this issue Oct 21, 2020
* [skip ci]
* disable the use of rebase
* eclipse-openj9/openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/openj9-openjdk-jdk8 that referenced this issue Oct 27, 2020
* [skip ci]
* disable the use of rebase
* eclipse-openj9/openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/openj9-openjdk-jdk8 that referenced this issue Nov 4, 2020
* [skip ci]
* disable the use of rebase
* eclipse-openj9/openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/openj9-openjdk-jdk8 that referenced this issue Nov 4, 2020
* [skip ci]
* disable the use of rebase
* eclipse-openj9/openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
jdekonin added a commit to jdekonin/openj9-openjdk-jdk8 that referenced this issue Nov 4, 2020
* [skip ci]
* disable the use of rebase
* eclipse-openj9/openj9#10129

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
@jdekonin
Copy link
Contributor

Can this be closed?

@pshipton
Copy link
Member Author

Yup, we've successfully transitioned to VS2013. Thanks for making this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants