Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(0.21.0) Disable cpu assert tests for out-of-process compilations #65

Merged
merged 2 commits into from
Jun 12, 2020
Merged

(0.21.0) Disable cpu assert tests for out-of-process compilations #65

merged 2 commits into from
Jun 12, 2020

Commits on Jun 11, 2020

  1. Disable cpu asserts for outOfProcessCompilations 

    Disabled the cpu related asserts for outOfProcessCompilations.
These asserts are meant to only test the correctness of new APIs
against old APIs for a single host processor and they fall apart
when we introduce remote target processors into the picture.

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
    @harryyu1994
    harryyu1994 committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    c272441 View commit details
    Browse the repository at this point in the history

  2. Make OMR::Compilation::_target protected 

    We need to have the ability to modify _target
in downstream Compilation classes. For example,
OpenJ9 would like to have a per-compilation target.

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
    @harryyu1994
    harryyu1994 committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    7f6aed9 View commit details
    Browse the repository at this point in the history