(0.21.0) Disable cpu assert tests for out-of-process compilations #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled the cpu related asserts for outOfProcessCompilations. These asserts are meant to only test the correctness of new APIs against old APIs for a single host processor and they fall apart when we introduce remote target processors into the picture. Signed-off-by: Harry Yu <harryyu1994@gmail.com>
We need to have the ability to modify _target in downstream Compilation classes. For example, OpenJ9 would like to have a per-compilation target. Signed-off-by: Harry Yu <harryyu1994@gmail.com>
|
Could you please add a more descriptive title, but also include 0.21 in the title |
harryyu1994
changed the title
harryyu1994
changed the title
mpirvu
approved these changes
Jun 11, 2020
pshipton
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled the cpu related asserts for out-of-process-compilations.
These asserts are meant to only test the correctness of new APIs
against old APIs for a single host processor and they fall apart
when we introduce remote target processors into the picture.
This is part of the changes that fixes blocker eclipse-openj9/openj9#9833
The other part is available in eclipse-openj9/openj9#9858
Original PR: eclipse-omr/omr#5298