(0.21.0) Implement ARM64Trg1Src2ZeroInstruction #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements ARM64Trg1Src2ZeroInstruction class so that we can stop setting register dependencies on the zero register in generating instructions for integer multiply. This commit also contains the following changes: - Implement and use insertZeroRegister() functions in classes introduced by eclipse-openj9#61 - Remove the code for printing "cmp" from ARM64Trg1Src2Instruction (It was moved to ARM64ZeroSrc2Instruction) Original PRs for master: eclipse-omr/omr#5289, eclipse-omr/omr#5290 Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
|
This is an AArch64-specific change. It was committed to OMR prior to the OpenJ9 split for 0.21.0, but because the OMR Acceptance build was broken it did not promote and wasn't part of the split. |
0xdaryl
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements ARM64Trg1Src2ZeroInstruction class so that we can
stop setting register dependencies on the zero register in generating
instructions for integer multiply.
This commit also contains the following changes:
(It was moved to ARM64ZeroSrc2Instruction)
Original PRs for master: eclipse-omr/omr#5289, eclipse-omr/omr#5290
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com