Simplify SupportsConst(I|L)Div to Supports(I|L)MulHigh #7095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesyou
requested review from
fjeremic,
aviansie-ben,
0xdaryl,
knn-k,
vijaysun-omr and
mstoodle
as code owners
github-actions
bot
added
arch:aarch32
arch:aarch64
arch:power
arch:x86
arch:z
comp:compiler
labels
jmesyou
removed request for
aviansie-ben,
mstoodle,
fjeremic,
0xdaryl and
vijaysun-omr
|
Jenkins build all,amac |
knn-k
reviewed
Aug 22, 2023
knn-k
reviewed
Aug 22, 2023
This is commit is motivated by openj9#17861. A check whether the underlying target supports 64 bit multiplication returning the high word is needed in order to intrinsify java.lang.Math.multiplyHigh As a side effect, this has simplified the SupportsConst(I|L)Div checks as they are transitive to the newly added checks Note this commit is a duplicate of PR#7082 due to a synchronized merge dependency. This commit differs in that getSupportsLowering(I|L)Div is retained to avoid the same issue for the downstream dependency. When the downstream dependency is eliminated, a future change will remove getSupportsLowering(I|L)Div Signed-off-by: James You <james.you@protonmail.com>
Previously, the multiply high feature flag was not enabled for aarch64. This change sets the flag and enables the fast constant division optimization. This is a duplicate of PR#7082 Signed-off-by: James You <james.you@protonmail.com>
jmesyou
force-pushed
the
refactor/const-div
branch
from
7fd14e5
to
1df35cd
Compare
|
Jenkins build all,amac |
knn-k
approved these changes
Aug 23, 2023
|
This PR does not require a coordinated merge with eclipse-openj9/openj9#17892 because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify SupportsConst(I|L)Div to Supports(I|L)MulHigh
This is motivated by openj9#17861.
A check whether the underlying target supports 64 bit
multiplication returning the high word is needed
in order to intrinsify java.lang.Math.multiplyHigh
As a side effect, this has simplified the
SupportsConst(I|L)Div checks as they are transitive
to the newly added checks
Note this commit is a duplicate of PR#7082 due to a
failed merge from a synchronized merge dependency.
This commit differs in that getSupportsLowering(I|L)Div is retained
to avoid the same issue for the OpenJ9 downstream dependency.
When the downstream dependency is eliminated, a future
change will remove getSupportsLowering(I|L)Div
Signed-off-by: James You james.you@protonmail.com