Simplify SupportsConst(I|L)Div to Supports(I|L)MulHigh #7082
Conversation
This is commit is motivated by openj9#17861. A check whether the underlying target supports 64 bit multiplication returning the high word is needed in order to intrinsify java.lang.Math.multiplyHigh As a side effect, this has simplified the SupportsConst(I|L)Div checks as they are transitive to the newly added checks Signed-off-by: James You <james.you@protonmail.com>
jmesyou
requested review from
fjeremic,
aviansie-ben,
0xdaryl,
knn-k,
vijaysun-omr and
mstoodle
as code owners
|
Please change the aarch64 code, too. |
See eclipse-omr/omr#7082 Depends on: eclipse-omr/omr#7082 Signed-off-by: James You <james.you@protonmail.com>
Previously, the multiply high feature flag was not enabled for aarch64. This change sets the flag and enables the fast constant division optimization. Signed-off-by: James You <james.you@protonmail.com>
|
@knn-k The aarch64 code gen did not originally set the |
|
Is there any reason for not setting the flag for IMulHigh on aarch64? I have the same question for LMulHigh on p.
|
|
I see no reason that it shouldn't be set. I did not set them because those code gens did not originally set the |
|
Other reviewers, any comments? |
|
Jenkins build all,amac |
|
Jenkins build win |
|
Jenkins build zlinux |
|
It didn't notice that I had to perform a coordinated merge with eclipse-openj9/openj9#17892. |
|
Reopened in #7095 |
This commit is motivated by eclipse-openj9/openj9#17861.
A check whether the underlying target supports 64 bit multiplication returning the high word is needed
in order to intrinsify java.lang.Math.multiplyHigh
As a side effect, this has simplified the
SupportsConst(I|L)Div checks as they are transitive to the newly added checks