AArch64: Fix helper trampoline lookup of ARM64Trg1SymImmInstruction #7083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMR eclipse-omr#7077 introduced the `callUsesHelperImplementation()` query to add a `TR_Helper` relocation for methods that are actually helper calls. That PR also changes the way the binary encoder finds necessary trampolines. Before OMR eclipse-omr#7077, `methodTrampolineLookup()` was used for call targets whose method object returns false for the `isHelper()` query. The behavior was changed to call `findHelperTrampoline()` instead of `methodTrampolineLookup()` if the `callUsesHelperImplementation()` query returns true. The problem is that the symbol reference for a certain method (which is actually a helper call) does not have a valid helper index as the reference number, thus causing `findHelperTrampoline` to return an incorrect address. This commit fixes the binary encoder to use `methodTrampolineLookup` for the call target whose method object returns false for the `isHelper()` query. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
|
Jenkins build aarch64,amac |
|
Jenkins build amac |
knn-k
approved these changes
Aug 1, 2023
This was referenced Aug 1, 2023
Akira1Saitoh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMR #7077 introduced the
callUsesHelperImplementation()query to add aTR_Helperrelocation for methods that are actually helper calls. That PR also changes the way the binary encoder finds necessary trampolines. Before OMR #7077,methodTrampolineLookup()was used for call targets whose method object returns false for theisHelper()query. The behavior was changed to callfindHelperTrampoline()instead ofmethodTrampolineLookup()if thecallUsesHelperImplementation()query returns true.The problem is that the symbol reference for a certain method (which is actually a helper call) does not have a valid helper index as the reference number, thus causing
findHelperTrampolineto return an incorrect address.This commit fixes the binary encoder to use
methodTrampolineLookupfor the call target whose method object returns false for theisHelper()query.