AArch64: Add callUsesHelperImplementation query to code generator #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `callUsesHelperImplementation` query to code generator. It updates `TR::ARM64ImmSymInstruction::generateBinaryEncoding()` function to add a `TR_Helper` relocation to the branch instruction if that query returns true for the symbol. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
|
Jenkins build aarch64,amac |
knn-k
approved these changes
Jul 28, 2023
Akira1Saitoh
pushed a commit
to Akira1Saitoh/omr
that referenced
this pull request
Aug 1, 2023
OMR eclipse-omr#7077 introduced `callUsesHelperImplementation()` query to add `TR_Helper` relocation for dispatchJ9Method call under out of process compilation. That PR also changes the binary encoder to use `findHelperTrampoline` for dispatchJ9Method. The symbol reference for that method does not have valid helper index as the reference number, thus `findHelperTTrampoline` returns an incorrect address. This commit fixes the binary encoder to use `methodTrampolineLookup` for the call target which is not a helper. Avoid using `findHelperTrampoline` for non-helper reference number. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Akira1Saitoh
pushed a commit
to Akira1Saitoh/omr
that referenced
this pull request
Aug 1, 2023
OMR eclipse-omr#7077 introduced the `callUsesHelperImplementation()` query to add a `TR_Helper` relocation for methods that are actually helper calls. That PR also changes the way the binary encoder finds necessary trampolines. Before OMR eclipse-omr#7077, `methodTrampolineLookup()` was used for call targets whose method object returns false for the `isHelper()` query. The behavior was changed to call `findHelperTrampoline()` instead of `methodTrampolineLookup()` if the `callUsesHelperImplementation()` query returns true. The problem is that the symbol reference for a certain method (which is actually a helper call) does not have a valid helper index as the reference number, thus causing findHelperTrampoline to return an incorrect address. This commit fixes the binary encoder to use `methodTrampolineLookup` for the call target whose method object returns false for the `isHelper()` query. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Akira1Saitoh
pushed a commit
to Akira1Saitoh/omr
that referenced
this pull request
Aug 1, 2023
OMR eclipse-omr#7077 introduced the `callUsesHelperImplementation()` query to add a `TR_Helper` relocation for methods that are actually helper calls. That PR also changes the way the binary encoder finds necessary trampolines. Before OMR eclipse-omr#7077, `methodTrampolineLookup()` was used for call targets whose method object returns false for the `isHelper()` query. The behavior was changed to call `findHelperTrampoline()` instead of `methodTrampolineLookup()` if the `callUsesHelperImplementation()` query returns true. The problem is that the symbol reference for a certain method (which is actually a helper call) does not have a valid helper index as the reference number, thus causing `findHelperTrampoline` to return an incorrect address. This commit fixes the binary encoder to use `methodTrampolineLookup` for the call target whose method object returns false for the `isHelper()` query. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
callUsesHelperImplementationquery to code generator. It updatesTR::ARM64ImmSymInstruction::generateBinaryEncoding()function to add aTR_Helperrelocation to the branch instruction if that query returns true for the symbol.