Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove callMustBeInlinedRegardlessOfSize #6991

Merged
merged 1 commit into from
May 30, 2023

Conversation

jmesyou
Copy link
Contributor

@jmesyou jmesyou commented May 12, 2023

This commit removes callMustBeInlinedRegardlessOfSize and all its uses since it has no overriding implementations.

Closes: #6148

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting the project, and congratulations on your first contribution! A project committer will shortly review your contribution. In the mean time, if you haven't had a chance please skim over the contribution guidelines which all pull requests must adhere to. If the ECA pull request check fails, have a look at the instructions for signing the ECA in the legal considerations section.

If you run into any problems our community will be happy to assist you in any way we can. There are a number of recommended ways to interact with the community. We encourage you to ask questions, or drop by to say hello.

This commit removes callMustBeInlinedRegardlessOfSize
and all its uses since it has no overriding implementations.

This commit depends on a downstream change to OpenJ9.

Closes: eclipse-omr#6148
Signed-off-by: James You <james.you@protonmail.com>
@0xdaryl
Copy link
Contributor

0xdaryl commented May 25, 2023

Jenkins build all

@0xdaryl
Copy link
Contributor

0xdaryl commented May 26, 2023

Jenkins build linux,x32linux

1 similar comment
@AdamBrousseau
Copy link
Contributor

Jenkins build linux,x32linux

@AdamBrousseau
Copy link
Contributor

jenkins build xlinux

@0xdaryl
Copy link
Contributor

0xdaryl commented May 30, 2023

I'm removing the "Depends on:" statements in your PR message. Nothing in OMR should ever depend on a downstream project, though the converse is often true.

@0xdaryl 0xdaryl merged commit 154735c into eclipse-omr:master May 30, 2023
@jmesyou jmesyou deleted the issue/6148 branch May 30, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate callMustBeInlinedRegardlessOfSize
3 participants