Skip to content

Commit

Permalink
Remove callMustBeInlinedRegardlessOfSize
Browse files Browse the repository at this point in the history
This commit removes callMustBeInlinedRegardlessOfSize
and all its uses since it has no overriding implementations.

This commit depends on a downstream change to OpenJ9.

Closes: #6148
Signed-off-by: James You <james.you@protonmail.com>
  • Loading branch information
jmesyou committed May 23, 2023
1 parent 779c51b commit 27aed6c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
12 changes: 1 addition & 11 deletions compiler/optimizer/Inliner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4256,13 +4256,6 @@ void TR_InlinerBase::applyPolicyToTargets(TR_CallStack *callStack, TR_CallSite *
return;
}

//return true if the call is dominated hot call
bool TR_InlinerBase::callMustBeInlinedRegardlessOfSize(TR_CallSite *callsite)
{

return false;
}

static bool traceIfMatchesPattern(TR::Compilation* comp)
{
static char* cRegex = feGetEnv ("TR_printIfRegex");
Expand Down Expand Up @@ -5505,10 +5498,7 @@ OMR_InlinerPolicy::callMustBeInlined(TR_CallTarget *calltarget)
bool
TR_InlinerBase::forceInline(TR_CallTarget *calltarget)
{
if (getPolicy()->callMustBeInlined(calltarget) || callMustBeInlinedRegardlessOfSize(calltarget->_myCallSite))
return true;

return false;
return getPolicy()->callMustBeInlined(calltarget);
}

void TR_CallSite::tagcalltarget(int32_t index, TR_InlinerTracer *tracer, TR_InlinerFailureReason reason)
Expand Down
1 change: 0 additions & 1 deletion compiler/optimizer/Inliner.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,6 @@ class TR_InlinerBase: public TR_HasRandomGenerator
void getSymbolAndFindInlineTargets(TR_CallStack *, TR_CallSite *, bool findNewTargets=true);

void applyPolicyToTargets(TR_CallStack *, TR_CallSite *);
bool callMustBeInlinedRegardlessOfSize(TR_CallSite *callsite);

bool forceInline(TR_CallTarget *calltarget);
bool forceVarInitInlining(TR_CallTarget *calltarget);
Expand Down

0 comments on commit 27aed6c

Please sign in to comment.