Make UnsupportedValueTypeOperation a recoverable exception #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UnsupportedValueTypeOperation exception extended CompilationException, which meant that, if it was thrown, compilation would be aborted. However, it should be considered a recoverable exception - if an unsupported operation is encountered during inlining, only the inlining of that particular method should be aborted while compilation of the outermost method continues. Fixed this by having UnsupportedValueTypeOperation extend RecoverableILGenException instead. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
andrewcraik
approved these changes
May 15, 2020
|
@genie-omr build all |
1 similar comment
|
@genie-omr build all |
|
The basic build is all clean so merging. |
wbh123456
pushed a commit
to wbh123456/omr
that referenced
this pull request
Jun 9, 2020
…ype-is-recoverable Make UnsupportedValueTypeOperation a recoverable exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UnsupportedValueTypeOperationexception extendedCompilationException, which meant that, if it was thrown, compilation would be aborted. However, it should be considered a recoverable exception - if an unsupported operation is encountered during inlining, only the inlining of that particular method should be aborted while compilation of the outermost method continues.Fixed this by having
UnsupportedValueTypeOperationextendRecoverableILGenExceptioninstead.Signed-off-by: Henry Zongaro zongaro@ca.ibm.com