Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omrsysinfo_processor_disable_feature API #4838

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

harryyu1994
Copy link
Contributor

This API is used for disabling features in OMRProcessorDesc.

Issue: #4339

Signed-off-by: Harry Yu harryyu1994@gmail.com

@harryyu1994
Copy link
Contributor Author

harryyu1994 commented Feb 20, 2020

Actually, having second thought on this one, this API may not be necessary.. Going to put this on hold and see how the review for #4744 goes.

@harryyu1994 harryyu1994 changed the title Add omrsysinfo_processor_disable_feature API WIP: Add omrsysinfo_processor_disable_feature API Feb 20, 2020
This API is used for disabling features in OMRProcessorDesc.

Issue: eclipse-omr#4339

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
@harryyu1994 harryyu1994 changed the title WIP: Add omrsysinfo_processor_disable_feature API Add omrsysinfo_processor_disable_feature API Feb 24, 2020
@harryyu1994
Copy link
Contributor Author

@rwy0717 This item is ready for review. Thanks!

@rwy7
Copy link
Contributor

rwy7 commented Mar 2, 2020

@genie-omr build all

@harryyu1994
Copy link
Contributor Author

@rwy0717 Hi Robert, tests passed, could we merge this?

@youngar youngar self-assigned this Mar 3, 2020
@youngar youngar merged commit f955e91 into eclipse-omr:master Mar 3, 2020
@harryyu1994 harryyu1994 deleted the portDisableFeature branch March 3, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants