-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update port library's processor detection APIs and enums #4803
Conversation
2e05fd8
to
4db58d0
Compare
The purpose of this change is to move x86's processor feature detection out of codegen and into the CPU class. We also would like the CPU class to use the port library for feature detection. I referenced this file(https://github.com/eclipse/omr/blob/master/compiler/x/runtime/X86Runtime.hpp) for the change. There are 3 steps to this whole thing and this change is step 1:
|
@0xdaryl @andrewcraik I've seen you guys review related changes before, could you guys take a look? |
a647477
to
cf82edb
Compare
@rwy0717 @0xdaryl @youngar @mstoodle @charliegracie Could anyone help review this one? thanks! |
c98cc51
to
cf1c4c9
Compare
I introduced another small change in "port/unix/omrsysinfo.c" that fixes a few Macro typos. |
ca0be11
to
5846477
Compare
Attaching the list of references used for this change, I figured this may help the reviewers:
OpenJ9's Processor Detection on x86 is all-over the place, there are 3 different variations in the code base with only one being up-to-date. OpenJ9 x86 codegen's implementation seems to be the most up-to-date one and is what I referenced(mostly). |
@genie-omr build all |
13:58:48 /home/jenkins/workspace/PullRequest-linux_390-64/port/common/omrsysinfo_helpers.c:41:19: fatal error: cpuid.h: No such file or directory
13:58:48 #include <cpuid.h>
13:58:48 ^
13:58:48 compilation terminated. Looking into it.. Should be disabled on non-x86 platforms |
This change involves updating the omrsysinfo_get_x86_description() API and a few enums. Issue: eclipse-omr#4339 Signed-off-by: Harry Yu <harryyu1994@gmail.com>
@rwy0717 Could we re-launch the builds/tests? |
@genie-omr build all |
@rwy0717 Thanks for the review, could this be merged now? Also, I'm wondering if you could review this short PR too(#4838). That one is related to port library cpu detection as well. |
This change involves updating the omrsysinfo_get_x86_description() API and
a few enums.
Issue: #4339
Signed-off-by: Harry Yu harryyu1994@gmail.com