Copy JUnit 5 tests for JUnit 6 testing #2619
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new entry delegates to JUnit 5, since we cant reference org.eclipse.jdt.junit6.runtime yet. Fixes: eclipse-jdt#2559
Contributor
Author
|
So far this includes changes for #2559. Its not a draft PR so we have test results - I'm not sure draft PRs have Jenkins jobs, if so, we can convert to draft. |
Contributor
Author
|
JUnit 5 changes in JDT and JDT UI, listed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=521750, were: To check if there were any tests among the changes, maybe it makes it easier to find JUnit 5 tests... |
New API was added org.eclipse.jdt.ui.unittest.junit.JUnitTestPlugin.JUnitVersion.JUNIT6 See eclipse-jdt#2560
Contributor
Author
|
I don't find anything else to copy. |
Contributor
Author
|
@iloveeclipse should I include the commit here on top of #2560? Or is it better to integrate them in different I-builds? |
Member
We can merge them together, why not? |
Contributor
Author
|
Included in: #2560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2618