-
Notifications
You must be signed in to change notification settings - Fork 109
Add JUnit test launch config entry for JUnit 6 #2560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Shouldn't this list be extended too: Lines 40 to 42 in f1f0280
|
I checked this too, I have some local changes so far. There are a lot of places where One place in particular we decide a test launch is a JUnit 5 test launch based on the test annotation... which is the same in JUnit 6. So no idea what to do with that spot. |
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
The only aproach I can think of at the moment is to somehow inspect what's on the classpath or in the launch-runtime and try to distinguish the available versions. |
org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/util/TestSearchEngine.java
Outdated
Show resolved
Hide resolved
9f54bb4 to
a020f2e
Compare
|
I'll check tomorrow. Full error is: |
I will push a fix to master to disable API checks for the new bundle for 4.38. |
|
If you plan to fix something, feel free to rebase on master before pushing to fix API warnings. |
The new entry delegates to JUnit 5, since we cant reference org.eclipse.jdt.junit6.runtime yet. Fixes: eclipse-jdt#2559
Should be fixed now. I noticed code in |
|
See also code in PDE that has extra case for JUnit 5 and now probably need to extend it to JUnit 6: |
|
There are two correct API warnings now on https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/PR-2560/8/apitools/new/ , which are not shown in IDE because of: And that because Not sure what to do now, if it would be part of SDK it would need proper version bump. I would vote for changing the version as if it would be in the baseline, because it makes sense from consumers point of view, even if it not part of the SDK. @trancexpress : please try to remove commit 9ca8f50 that increases service version and instead bump version of @mickaelistria, @jjohnstn , @akurtakov : any idea why |
New API was added org.eclipse.jdt.ui.unittest.junit.JUnitTestPlugin.JUnitVersion.JUNIT6 See eclipse-jdt#2560
New API was added org.eclipse.jdt.ui.unittest.junit.JUnitTestPlugin.JUnitVersion.JUNIT6 See eclipse-jdt#2560
New API was added org.eclipse.jdt.ui.unittest.junit.JUnitTestPlugin.JUnitVersion.JUNIT6 See eclipse-jdt#2560
org.eclipse.jdt.junit.core/src/org/eclipse/jdt/internal/junit/util/CoreTestSearchEngine.java
Show resolved
Hide resolved
org.eclipse.jdt.junit.core/src/org/eclipse/jdt/internal/junit/util/CoreTestSearchEngine.java
Show resolved
Hide resolved
New API was added org.eclipse.jdt.ui.unittest.junit.JUnitTestPlugin.JUnitVersion.JUNIT6 See eclipse-jdt#2560
|
I've pushed a fix for this problem: #2618 (comment) Of the 3 JUnit 5 test cases I've found (I hope there are more), there are still some fails. Potentially we'll have to follow this PR up with fixes. |
|
@iloveeclipse from my POV we can merge this. |
New API was added org.eclipse.jdt.ui.unittest.junit.JUnitTestPlugin.JUnitVersion.JUNIT6 See #2560


Fixes: #2559
What it does
How to test
Author checklist