Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2130 Merge 'iceoryx_dust' back to 'iceoryx_hoofs' #2133

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 12, 2023

Pre-Review Checklist for the PR Author

  1. Add a second reviewer for complex new features or larger refactorings
  2. Code follows the coding style of CONTRIBUTING.md
  3. Tests follow the best practice for testing
  4. Changelog updated in the unreleased section including API breaking changes
  5. Branch follows the naming format (iox-123-this-is-a-branch)
  6. Commits messages are according to this guideline
  7. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. Relevant issues are linked
  9. Add sensible notes for the reviewer
  10. All checks have passed (except task-list-completed)
  11. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. Assign PR to reviewer

Notes for Reviewer

This PR moves all files for iceoryx_dust to iceoryx_hoofs and removes iceoryx_dust.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the refactoring Refactor code without adding features label Dec 12, 2023
@elBoberido elBoberido self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #2133 (7095220) into master (79f038b) will decrease coverage by 0.02%.
The diff coverage is 90.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2133      +/-   ##
==========================================
- Coverage   80.24%   80.22%   -0.02%     
==========================================
  Files         418      418              
  Lines       16163    16172       +9     
  Branches     2253     2255       +2     
==========================================
+ Hits        12970    12974       +4     
- Misses       2398     2399       +1     
- Partials      795      799       +4     
Flag Coverage Δ
unittests 80.01% <90.00%> (-0.02%) ⬇️
unittests_timing 15.26% <2.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
iceoryx_hoofs/cli/include/iox/cli/arguments.inl 58.82% <100.00%> (ø)
...eoryx_hoofs/cli/include/iox/cli/option_manager.inl 73.33% <ø> (ø)
iceoryx_hoofs/cli/source/arguments.cpp 100.00% <ø> (ø)
iceoryx_hoofs/cli/source/option_definition.cpp 100.00% <100.00%> (ø)
iceoryx_hoofs/cli/source/option_manager.cpp 84.61% <100.00%> (ø)
...er/include/iox/detail/fixed_position_container.inl 96.93% <100.00%> (ø)
...oofs/container/include/iox/detail/forward_list.inl 92.20% <ø> (ø)
...container/include/iox/fixed_position_container.hpp 100.00% <ø> (ø)
...oofs/container/include/iox/uninitialized_array.hpp 100.00% <ø> (ø)
...eoryx_hoofs/filesystem/include/iox/file_reader.hpp 100.00% <ø> (ø)
... and 20 more

... and 1 file with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-2130-merge-dust-back-to-hoofs branch from 1bb4df7 to 9ff9597 Compare December 12, 2023 20:24
Comment on lines +1 to +2
6.4.0
# NOTE: Bazel 7.0 errors out on 'buildifier_lint_check' with a hint to 'go_register_toolchains' in 'setup.bzl'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkroenke maybe you have more luck than me but I was not able to get the linter working with the latest bazel release from yesterday.

@elBoberido
Copy link
Member Author

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @budrus @elfenpiff feel free to add yourself as reviewer

@elfenpiff elfenpiff self-requested a review December 18, 2023 15:23
@elBoberido elBoberido merged commit 154b5a5 into eclipse-iceoryx:master Dec 18, 2023
25 checks passed
@elBoberido elBoberido deleted the iox-2130-merge-dust-back-to-hoofs branch December 18, 2023 16:07
@elBoberido elBoberido linked an issue Dec 18, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge 'iceoryx_dust' back to 'iceoryx_hoofs'
2 participants