Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 'iceoryx_dust' back to 'iceoryx_hoofs' #2130

Closed
elBoberido opened this issue Dec 8, 2023 · 1 comment · Fixed by #2132 or #2133
Closed

Merge 'iceoryx_dust' back to 'iceoryx_hoofs' #2130

elBoberido opened this issue Dec 8, 2023 · 1 comment · Fixed by #2132 or #2133
Labels
refactoring Refactor code without adding features

Comments

@elBoberido
Copy link
Member

elBoberido commented Dec 8, 2023 •
edited
Loading

Brief feature description

As decided in the developer meetup from 2023-12-05, iceoryx_dust will be merged back to iceoryx_hoofs

https://github.com/eclipse-iceoryx/iceoryx/wiki/2023-12-05-Eclipse-iceoryx-developer-meetup#minutes

Detailed information

The split was partially arbitrary since there are classes in iceoryx_dust which are used in iceoryx_posh and need to be quality level 1 or 1+. It is upon downstream to decide which classes to use, even it they are not used by iceoryx_posh. We as upstream just need to make downstream aware of the quality level of each header.

This can be done by a matrix like the following (just a suggestion, TBD)

Component Coverage clang-tidy Axivion ...
iox/vector ~100% ✅ ✅
iox/detail/convert ~80% ✅ ❌

If we include tools like Axivion in the matrix, we also need to state the rules which are followed else it is not possible for upstream to cooperate. It is totally fine though if this is just something that downstream adds but then it cannot be a criteria in the matrix.

Note: The part with the more fine grained list of quality levels is moved to #2182
@elBoberido elBoberido added the refactoring Refactor code without adding features label Dec 8, 2023
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 8, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Move 'convert' to 'iceoryx_hoofs'
e3fdb93
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 8, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Fix binding-C publisher options test
59f6ccd
@elBoberido elBoberido mentioned this issue Dec 8, 2023
Merged
22 tasks
elBoberido added a commit that referenced this issue Dec 9, 2023
@elBoberido
Merge pull request #2132 from elBoberido/iox-2130-move-convert-to-hoofs
79f038b 
iox-#2130 Move 'convert' to 'iceoryx_hoofs'
@elBoberido elBoberido linked a pull request Dec 9, 2023 that will close this issue
iox-#2130 Move 'convert' to 'iceoryx_hoofs' #2132
Merged
22 tasks
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Move 'vocabulary' types from 'iceoryx_dust' …
fa58f6e 
…to 'iceoryx_hoofs'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Update README
d5eaa65
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Move 'container' types from 'iceoryx_dust' t…
ba3942b 
…o 'iceoryx_hoofs'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Scan all files in the 'container' module
ff5e7f2
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Move 'filesystem' types from 'iceoryx_dust' …
08967a7 
…to 'iceoryx_hoofs'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Move 'utility' types from 'iceoryx_dust' to …
4e69337 
…'iceoryx_hoofs'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Move 'memory' types from 'iceoryx_dust' to '…
d63ec9d 
…iceoryx_hoofs'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Move 'ipc' types from 'iceoryx_dust' to 'ice…
28908d6 
…oryx_hoofs'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Move 'sync' types from 'iceoryx_dust' to 'ic…
726128f 
…eoryx_hoofs'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Move 'cli' types from 'iceoryx_dust' to 'ice…
c3677c0 
…oryx_hoofs'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Remove 'iceoryx_dust'
b323a66
@elBoberido elBoberido mentioned this issue Dec 12, 2023
Merged
22 tasks
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Revert from 'function_ref' to 'function'
ab5f47d
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Add missing include
8c04f2b
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Remove dust test from cirrus-ci
10d4de6
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Use 'std::abort' instead of 'std::quick_exit'
c3d6a1c
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Fix bazel build
0f5b264
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Pin bazel to a fixed version
1bb4df7
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Pin bazel to a fixed version
9ff9597
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Dec 12, 2023
@elBoberido
iox-eclipse-iceoryx#2130 Remove debug code
7095220
elBoberido added a commit that referenced this issue Dec 18, 2023
@elBoberido
Merge pull request #2133 from elBoberido/iox-2130-merge-dust-back-to-…
154b5a5 
…hoofs

iox-#2130 Merge 'iceoryx_dust' back to 'iceoryx_hoofs'
@elBoberido elBoberido linked a pull request Dec 18, 2023 that will close this issue
iox-#2130 Merge 'iceoryx_dust' back to 'iceoryx_hoofs' #2133
Merged
22 tasks
@elBoberido elBoberido mentioned this issue Feb 4, 2024
Open
@elBoberido
Copy link
Member Author

Closing this issue. The remaining tasks are moved to #2182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Refactor code without adding features
Projects
None yet
Milestone
No milestone
1 participant
@elBoberido