Skip to content

SSE Flow.Subscriber injectable as event sink #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
senivam merged 1 commit into from
Sep 23, 2020
Merged

SSE Flow.Subscriber injectable as event sink #4503

senivam merged 1 commit into from
Sep 23, 2020

Conversation

@danielkec
Copy link
Contributor

@danielkec danielkec commented Jun 10, 2020 •
edited
Loading

Fixes #4501
Fixes #4500

Now its possible in Java 11+

    @GET
    @Path("sse")
    @Produces(MediaType.SERVER_SENT_EVENTS)
    public void listenToEvents(@Context java.util.concurrent.Flow.Subscriber<String> eventSink)
    public void listenToEvents(@Context java.util.concurrent.Flow.Subscriber<OutboundEvent> eventSink)
    public void listenToEvents(@Context org.glassfish.jersey.internal.jsr166.Flow.Subscriber<String> eventSink)
    public void listenToEvents(@Context org.glassfish.jersey.internal.jsr166.Flow.Subscriber<OutboundEvent> eventSink)

Java 8

    @GET
    @Path("sse")
    @Produces(MediaType.SERVER_SENT_EVENTS)
    public void listenToEvents(@Context org.glassfish.jersey.internal.jsr166.Flow.Subscriber<String> eventSink)
    public void listenToEvents(@Context org.glassfish.jersey.internal.jsr166.Flow.Subscriber<OutboundEvent> eventSink)

@danielkec danielkec force-pushed the 4501-flow-subscriber-sse branch 2 times, most recently from cb3d761 to 4fec414 Compare June 11, 2020 08:49
@tomas-langer tomas-langer requested a review from jansupol June 11, 2020 09:08
@danielkec danielkec force-pushed the 4501-flow-subscriber-sse branch from 804558d to a3c9ad4 Compare June 11, 2020 18:04
@danielkec danielkec changed the title [WIP] SSE Flow.Subscriber injectable as event sink SSE Flow.Subscriber injectable as event sink Jun 11, 2020
@danielkec danielkec changed the title SSE Flow.Subscriber injectable as event sink [WIP] SSE Flow.Subscriber injectable as event sink Jun 12, 2020
@danielkec danielkec force-pushed the 4501-flow-subscriber-sse branch from a446b68 to a014999 Compare June 12, 2020 14:42
@danielkec danielkec force-pushed the 4501-flow-subscriber-sse branch 2 times, most recently from acf87ab to 58d0a4f Compare June 15, 2020 12:41
@danielkec danielkec force-pushed the 4501-flow-subscriber-sse branch 2 times, most recently from d2d7cd3 to 680068c Compare August 3, 2020 15:02
@danielkec danielkec changed the title [WIP] SSE Flow.Subscriber injectable as event sink SSE Flow.Subscriber injectable as event sink Aug 4, 2020
@danielkec danielkec requested a review from jansupol August 4, 2020 10:38
jansupol
jansupol requested changes Sep 16, 2020
View reviewed changes
@danielkec danielkec requested a review from jansupol September 21, 2020 20:09
@danielkec
SSE Flow.Subscriber injectable as event sink
e2ba486 
  * Java Flow api used only by JerseyEventSink in java 11+
  * Reactive streams tck tests for JerseyEventSink
  * Cancel on close propagation
  * Remove tests contradicting reactive streams spec https://github.com/reactive-streams/reactive-streams-jvm#2.13

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec force-pushed the 4501-flow-subscriber-sse branch from cb5eca9 to e2ba486 Compare September 23, 2020 13:56
@danielkec
Copy link
Contributor Author

danielkec commented Sep 23, 2020

Sorry for the force push, conflicts solved ...

senivam
senivam approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senivam senivam merged commit 0f65e5d into eclipse-ee4j:master Sep 23, 2020
@senivam senivam added this to the 2.32 milestone Sep 25, 2020
@renovate renovate bot mentioned this pull request Jun 26, 2021
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Apr 17, 2022
Closed
This was referenced May 3, 2022
Open
Open
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
This was referenced Oct 19, 2022
Closed
Closed
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Mar 26, 2023
Closed
This was referenced Jun 15, 2023
Merged
Merged
@renovate renovate bot mentioned this pull request Jul 6, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 4, 2023
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Closed
This was referenced Apr 13, 2024
Merged
Closed
@renovate renovate bot mentioned this pull request Feb 18, 2025
Closed
1 task
This was referenced Feb 23, 2025
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Apr 29, 2025
Closed
1 task
This was referenced May 26, 2025
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Oct 5, 2025
Merged
1 task
@renovate-bot renovate-bot mentioned this pull request Nov 18, 2025
Closed
1 task
@renovate renovate bot mentioned this pull request Nov 18, 2025
Closed
1 task
@renovate-bot renovate-bot mentioned this pull request Nov 19, 2025
Closed
1 task
@renovate renovate bot mentioned this pull request Nov 23, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomas-langer tomas-langer tomas-langer left review comments

@jansupol jansupol jansupol approved these changes

@senivam senivam senivam approved these changes

Assignees

@danielkec danielkec

Labels

None yet

Projects

None yet

Milestone

2.32

Development

Successfully merging this pull request may close these issues.

SSE Endpoint should be able to inject Flow.Subscriber JerseyEventSink shouln't throw exceptions in Flow.Subscriber methods

4 participants

@danielkec @tomas-langer @jansupol @senivam