[core] new-datarw-connection-logic #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get IsPublished/IsSubscribed (and the connection events) only if the connection is fully established connection state need now a second registration loop to get fully active Send(), Receive() functions are not affected by the new state handling test added to check correct IsPublished() and IsSubscribed() behavior
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <string> | ||
| #include <thread> | ||
|
|
||
| #include <gtest/gtest.h> |
There was a problem hiding this comment.
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
#include <gtest/gtest.h>
^|
|
||
| #include <gtest/gtest.h> | ||
|
|
||
| TEST(core_cpp_pubsub, TestSubscriberIsPublishedTiming) |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
| TEST(core_cpp_pubsub, TestSubscriberIsPublishedTiming) | |
| TEST(core_cpp_pubsub /*unused*/, TestSubscriberIsPublishedTiming /*unused*/) |
| std::string first_received_sample; | ||
| auto subscriber_thread = [&]() { | ||
| eCAL::CSubscriber sub("blob"); | ||
| bool received(false); |
There was a problem hiding this comment.
warning: variable 'received' of type 'bool' can be declared 'const' [misc-const-correctness]
Suggested change
| bool received(false); | |
| bool const received(false); |
| eCAL::Finalize(); | ||
| } | ||
|
|
||
| TEST(core_cpp_pubsub, TestPublisherIsSubscribedTiming) |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
| TEST(core_cpp_pubsub, TestPublisherIsSubscribedTiming) | |
| TEST(core_cpp_pubsub /*unused*/, TestPublisherIsSubscribedTiming /*unused*/) |
| std::string first_received_sample; | ||
| auto subscriber_thread = [&]() { | ||
| eCAL::CSubscriber sub("blob"); | ||
| bool received(false); |
There was a problem hiding this comment.
warning: variable 'received' of type 'bool' can be declared 'const' [misc-const-correctness]
Suggested change
| bool received(false); | |
| bool const received(false); |
…com/eclipse-ecal/ecal into feature/new-datarw-connection-logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor connection state logic for DataReader/Writer (Sub/Pub)