feat(Publisher): implement the send_with_time() method #9
Conversation
This method let the caller set the time of the message, like the original Send() of eCAL
|
Hey @Bnz-0, thanks for the PR. Sorry for the delay in reviewing it. We don't currently use ecal ourselves so it hasn't been a priority, and that also unfortunately means that I'm not very knowledgeable about it. This looks good, though. Thanks! We can draft a new release once I've merged your other PRs. |
|
Seems something is wrong with CI but it's not your fault. I'll look into that now. |
|
@Bnz-0 I believe CI is working fine again now. Would you mind syncing your PRs with the current |
|
@alknemeyer I synchronized all the PRs. Let me know if there are other issues. |
|
Thanks, LGTM! Apologies again for the delays, I appreciate your patience. |
|
Hey @Bnz-0, I've published a new release. Let me know if you have any issues using it -- my employer doesn't use this package at the moment, so I can't say that we've deployed and tested it properly. |
|
I tried the 0.2.0 juts now and it works perfectly 👍, thank a lot! |
|
Great, I'm glad to hear! Thanks again for your PRs and feedback. |
This method let the caller set the time of the message, like the original Send() of eCAL