Fix get matched publication crash #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboasson
force-pushed
the
fix-get-matched-publication-crash
branch
from
b5a3962
to
317784a
Compare
Signed-off-by: Erik Boasson <eb@ilities.com>
This crashed because the built-in topics are published by a "local orphan writer" that is not contained in a participant, causing dds_get_matched_publication_data to crash on dereferencing a null pointer. Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson
force-pushed
the
fix-get-matched-publication-crash
branch
from
317784a
to
43560b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1851