Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Machine.getOwner should provide userId and not namespace #3366

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Machine.getOwner should provide userId and not namespace #3366

merged 1 commit into from
Dec 14, 2016

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Dec 13, 2016 •
edited
Loading

What does this PR do?

What issues does this PR fix or reference?

Fix #3042

Previous behavior

Machine.getOwner() was returning namespace

New behavior

machine.getOwner() is returning userId and not a namespace

Change-Id: I64b4cd3931fec502073ead0115a312430f2434b8
Signed-off-by: Florent BENOIT fbenoit@codenvy.com

@sleshchenko
Copy link
Member

But please fix commit message, because as for me Fix #3042 is bad commit message.

@benoitf
Copy link
Contributor Author

benoitf commented Dec 13, 2016 •
edited
Loading

@sleshchenko
commit message is

Fix #3042
machine.getOwner() should return userId and not a namespace

The first line Fix is for https://help.github.com/articles/closing-issues-via-commit-messages/

@sleshchenko
Copy link
Member

sleshchenko commented Dec 13, 2016 •
edited
Loading

Yes, let me correct me. Please fix commit subject 😄 Fix #3042 is commit subject and machine.getOwn... not a namespace is message commit body. That why we'll see only Fix #3042 by default with github, gitg or gitk. So it would be better to see clear message without check commit details

@benoitf
machine.getOwner() should return userId and not a namespace
88a9a7e 
Fix #3042

Change-Id: I64b4cd3931fec502073ead0115a312430f2434b8
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf
Copy link
Contributor Author

benoitf commented Dec 13, 2016 •
edited
Loading

@sleshchenko I've switched commit subject and commit body

@sleshchenko
Copy link
Member

sleshchenko commented Dec 13, 2016 •
edited
Loading

Cool.

The first line Fix is for https://help.github.com/articles/closing-issues-via-commit-messages/

It's new information for me. Thx 👍

@bmicklea bmicklea added this to the 5.0.0-M9 milestone Dec 13, 2016
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1306/

@benoitf benoitf merged commit 5266cd9 into master Dec 14, 2016
@benoitf benoitf deleted the CHE-3042 branch December 14, 2016 09:01
@benoitf benoitf self-assigned this Dec 14, 2016
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
@benoitf
machine.getOwner() should return userId and not a namespace (eclipse-…
1ba96ae 
…che#3366)

Fix eclipse-che#3042

Change-Id: I64b4cd3931fec502073ead0115a312430f2434b8
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

Assignees

@benoitf benoitf

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

machine.getOwner() should return userId and not namespace
5 participants
@benoitf @sleshchenko @codenvy-ci @skabashnyuk @bmicklea