Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machine.getOwner() should return userId and not namespace #3042

Closed
benoitf opened this issue Nov 10, 2016 · 2 comments · Fixed by #3366
Closed

machine.getOwner() should return userId and not namespace #3042

benoitf opened this issue Nov 10, 2016 · 2 comments · Fixed by #3366
Assignees
@benoitf
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Milestone
5.0.0

Comments

@benoitf
Copy link
Contributor

benoitf commented Nov 10, 2016

When calling machine.getOwner() it returns a namespace while it should return userId
https://github.com/eclipse/che/blob/master/plugins/plugin-docker/che-plugin-docker-machine/src/main/java/org/eclipse/che/plugin/docker/machine/MachineProviderImpl.java#L313-313

Che version: 5.0.0-M7-SNAPSHOT

Additional information:

  • Problem can be reliably reproduced, doesn't happen randomly: [Yes]
@benoitf benoitf added this to the 5.0.0-M8 milestone Nov 10, 2016
@benoitf benoitf self-assigned this Nov 10, 2016
@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. sprint/next and removed sprint/next labels Nov 10, 2016
@benoitf benoitf mentioned this issue Nov 10, 2016
Merged
@benoitf
Copy link
Contributor Author

benoitf commented Nov 10, 2016

creator should be used
https://github.com/eclipse/che/blob/master/wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/environment/server/CheEnvironmentEngine.java#L348-348

@benoitf
Copy link
Contributor Author

benoitf commented Nov 10, 2016

and revert https://github.com/eclipse/che/blob/20556a8ed2a2b1fb14bb632633de6cdc1591faf7/plugins/plugin-machine/che-plugin-machine-ext-server/src/main/java/org/eclipse/che/ide/ext/machine/server/ssh/KeysInjector.java#L86-L92

@garagatyi garagatyi added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/platform labels Nov 15, 2016
@benoitf benoitf modified the milestones: 5.0.0-M9, 5.0.0-M8 Nov 22, 2016
benoitf added a commit that referenced this issue Dec 13, 2016
@benoitf
Fix #3042
4cad261 
machine.getOwner() should return userId and not a namespace

Change-Id: I64b4cd3931fec502073ead0115a312430f2434b8
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf benoitf mentioned this issue Dec 13, 2016
Merged
@benoitf benoitf added sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Dec 13, 2016
benoitf added a commit that referenced this issue Dec 13, 2016
@benoitf
machine.getOwner() should return userId and not a namespace
88a9a7e 
Fix #3042

Change-Id: I64b4cd3931fec502073ead0115a312430f2434b8
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf added a commit that referenced this issue Dec 14, 2016
@benoitf
machine.getOwner() should return userId and not a namespace (#3366)
5266cd9 
Fix #3042

Change-Id: I64b4cd3931fec502073ead0115a312430f2434b8
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@benoitf benoitf removed sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Dec 14, 2016
@bmicklea bmicklea mentioned this issue Jan 13, 2017
Closed
70 tasks
JPinkney pushed a commit to JPinkney/che that referenced this issue Aug 17, 2017
@benoitf
machine.getOwner() should return userId and not a namespace (eclipse-…
1ba96ae 
…che#3366)

Fix eclipse-che#3042

Change-Id: I64b4cd3931fec502073ead0115a312430f2434b8
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Machine.getOwner should provide userId and not namespace eclipse-che/che
3 participants
@benoitf @skabashnyuk @garagatyi