Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename root artifactId id to che-server #18639

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Rename root artifactId id to che-server #18639

merged 1 commit into from
Dec 17, 2020

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Dec 17, 2020 •
edited
Loading

What does this PR do?

Distinguish parent artifactId from eclipse/che-parent root pom.xml

Screenshot/screencast of this PR

What issues does this PR fix or reference?

artifactId che-parent are confusing. Because it overlaps with https://github.com/eclipse/che-parent/blob/master/pom.xml#L18 .
Follow up of #18629 (review)

How to test this PR?

  • mvn clean install

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@skabashnyuk
Rename root artifact id to che-server
4f9fed3 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Dec 17, 2020
sparkoo
sparkoo approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@sparkoo sparkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built fine

@che-bot
Copy link
Contributor

che-bot commented Dec 17, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@skabashnyuk skabashnyuk merged commit 3b9601c into eclipse-che:master Dec 17, 2020
@skabashnyuk skabashnyuk deleted the renameparent branch December 17, 2020 10:35
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 17, 2020
@mkuznyetsov mkuznyetsov mentioned this pull request Jan 11, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparkoo sparkoo sparkoo approved these changes

@amisevsk amisevsk Awaiting requested review from amisevsk

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp

@metlos metlos Awaiting requested review from metlos

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@rhopp rhopp Awaiting requested review from rhopp

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skabashnyuk @che-bot @sparkoo