Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Sonar check for master and Github pull requests #18629

Merged
merged 5 commits into from
Dec 17, 2020
Merged

Setup Sonar check for master and Github pull requests #18629

merged 5 commits into from
Dec 17, 2020

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Dec 16, 2020 •
edited
Loading

What does this PR do?

Setup Sonar check for master and Github pull requests. Results can be found here https://sonarcloud.io/dashboard?id=org.eclipse.che%3Ache-server
I`ve decided not to change che-parent. But first, get stable sonar testing results, and after that with @nickboldt @mkuznyetsov can decide whatever we should move the sonar config to https://github.com/eclipse/che-parent or not.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#18507

How to test this PR?

  • Setup SONAR_TOKEN
  • mvn -B clean verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Psonar -Pintegration

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@skabashnyuk
Setup Sonar check for master and Github pull requests
98202ef 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Dec 16, 2020
@skabashnyuk skabashnyuk linked an issue Dec 16, 2020 that may be closed by this pull request
Setup SonarCloud for Che server #18507
Closed
@dmytro-ndp
Copy link
Contributor

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Dec 16, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@dmytro-ndp
Copy link
Contributor

[crw-ci-test --rebuild]

@che-bot
Copy link
Contributor

che-bot commented Dec 16, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Dec 16, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

Use command [ci-test] to rerun the test.

@skabashnyuk
Setup token from secret
13c3cb0 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Dec 16, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@skabashnyuk
Revert "Setup token from secret"
984cedf 
This reverts commit 13c3cb0.

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
Copy link
Contributor Author

[crw-ci-test]

@skabashnyuk
Copy link
Contributor Author

[ci-build]

@skabashnyuk
Copy link
Contributor Author

Sonar / Sonar (pull_request) failing - that is ok because it has no access to secrets.

@che-bot
Copy link
Contributor

che-bot commented Dec 16, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@sparkoo
Copy link
Member

sparkoo commented Dec 17, 2020

Sonar / Sonar (pull_request) failing - that is ok because it has no access to secrets.

it will have an access once it's in the master?

sparkoo
sparkoo reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@sparkoo sparkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is rename che-parent to che-server required for this task? If not, I would consider do it in 2 PRs.

@skabashnyuk
Copy link
Contributor Author

it will have an access once it's in the master?

I'm really, really hope so.

Is rename che-parent to che-server required for this task?

No.

If not, I would consider do it in 2 PRs.

oookey

@skabashnyuk skabashnyuk mentioned this pull request Dec 17, 2020
Merged
9 tasks
@skabashnyuk
Merge remote-tracking branch 'upstream/master' into sonar
9f1196f 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
fixup! Merge remote-tracking branch 'upstream/master' into sonar
2e70e88 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Dec 17, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Dec 17, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@skabashnyuk skabashnyuk merged commit 5149322 into eclipse-che:master Dec 17, 2020
@skabashnyuk skabashnyuk deleted the sonar branch December 17, 2020 11:21
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparkoo sparkoo sparkoo left review comments

@mshaposhnik mshaposhnik mshaposhnik approved these changes

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@amisevsk amisevsk Awaiting requested review from amisevsk

@metlos metlos Awaiting requested review from metlos

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@rhopp rhopp Awaiting requested review from rhopp

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup SonarCloud for Che server
5 participants
@skabashnyuk @dmytro-ndp @che-bot @sparkoo @mshaposhnik