Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#44 Export - use JumpPosition #62

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

merktj
Copy link
Collaborator

@merktj merktj commented Feb 8, 2021

As discussed to fix #44, for blocks with zero-duration a JumpPosition flag should be set. If there are multiple points at the same timestamp, the current implementation always creates 2 blocks, where the second block has zero-duration and by using the already existing flags, a JumpPosition for this block can be set.

…that is created if multiple automation points are placed on same timestamp.
Copy link
Contributor

@firthm01 firthm01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Also tested and works as expected.

@rsjbailey rsjbailey merged commit 5ca119e into ebu:main Mar 25, 2021
@firthm01 firthm01 mentioned this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export - use JumpPosition
3 participants