-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export - use JumpPosition #44
Comments
If there are multiple points at the same timestamp, the current implementation always creates 2 blocks. The first block defines the interpolation towards the first point and the second block the interpolation between the first and the last point on the timestamp, but the duration of second block equals 0. Regarding the threshold for minimum distance, is there a reference where this is described? Unfortunately so far I couldn't find one. |
Having looked in to this again, I think this all arose from testing with Dolby. The minimum block duration comes from the Dolby ADM profile which specifies that blocks within 2ms of a 'breakpoint' can be discarded, and that jumpPosition should be used when instant changes are required. (section 2.5.1 of https://developer.dolby.com/globalassets/documentation/technology/dolby_atmos_master_adm_profile_v1.0.pdf) |
Use jump position where we have 2 points on the same timestamp, rather than 2 blocks.
Future - there's actually a threshold for minimum distance between blocks - this jump position logic should apply to create a ramp over a set duration without placing points too close to each other (bear in mind, what if you have >2 points tightly clustered?)
From gitlab 38
The text was updated successfully, but these errors were encountered: